Portfolio Lab#1
Open
Denae716 wants to merge 2 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Open
Conversation
kburd
reviewed
Oct 29, 2020
| @@ -0,0 +1 @@ | |||
| testing pg 1 | |||
There was a problem hiding this comment.
Only commit important files. This text file doesn't have any value
| <header> | ||
| <a href="pg2.html">Contact</a> | ||
| <h1>Denae Brown</h1> | ||
| <img src="C:\Users\denae\Portfolio-Lab\page.1.HTML\Me.JPG" alt="photo of me"/> |
There was a problem hiding this comment.
Image did not load correctly, you used an absolute file path. If you used a relative one like Me.JPG it would have loaded on mine as well as yours (-1)
| <h1>Contact Me</h1> | ||
| <hr> | ||
| <label for="firstname">First Name</label><br> | ||
| <input required type="text" id="firstname" name="firstName"> <br><br> |
| <input required type="text" id="firstname" name="firstName"> <br><br> | ||
|
|
||
| <label for="lastname">Last Name </label><br> | ||
| <input required type="text" id="lastname" name="lastName"> <br><br> |
| <button>Submit</button> | ||
|
|
||
| </body> | ||
| </html> No newline at end of file |
There was a problem hiding this comment.
Missing How did you hear about us dropdown (-5)
80/100
Great work! My only recommendation is to make sure you do everything the lab asks for. You missed some points on silly mistakes.
|
|
||
|
|
||
| <label for="interest">Skills of Interest</label> | ||
| <select> |
There was a problem hiding this comment.
Should be checkboxes instead of dropdown (-3)
|
|
||
|
|
||
| <label for="comments">Comments</label><br> | ||
| <textarea name="comments" cols="50" row="10" maxlength="300"></textarea> <br> |
There was a problem hiding this comment.
Should be a max length of 250, not 300 (-1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.